Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve URL detection in mod_pagespeed check #12024

Closed
tsteur opened this issue Sep 10, 2017 · 6 comments · Fixed by #19595
Closed

Improve URL detection in mod_pagespeed check #12024

tsteur opened this issue Sep 10, 2017 · 6 comments · Fixed by #19595
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
4.12.0

Comments

@tsteur
Copy link
Member

tsteur commented Sep 10, 2017

While testing #12019 I noticed I get the error

INFO [2017-09-08 12:16:39] Unable to test if mod_pagespeed is enabled: the request to http://unknown/./console?module=Installation&action=getEmptyPageForSystemCheck failed

when executing ./console diagnostics:run

I searched for similar issues but they seem different. Seems like Url::getCurrentUrlWithoutQueryString() does not return a URL.
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 10, 2017
@tsteur
Copy link
Member Author

tsteur commented May 14, 2018

Might be better to use SettingsPiwik::getPiwikUrl() or so

@Qixuga Qixuga mentioned this issue Jun 26, 2018
Closed
@alexhass
Copy link

Bug still exists in 4.5

@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Oct 12, 2021
@tsteur tsteur added this to the 4.8.0 milestone Oct 12, 2021
@joan31
Copy link

joan31 commented Oct 12, 2021

I confirm, bug still exist on Matomo 4.5

image

@asheroto
Copy link

asheroto commented Dec 1, 2021

Bug exists still

@tsteur
Copy link
Member Author

tsteur commented Jan 13, 2022

Let's use SettingsPiwik::getPiwikUrl() and if we don't get a URL from this method then we just skip this test.

@tsteur tsteur modified the milestones: 4.8.0, 4.9.0 Feb 9, 2022
@tsteur tsteur modified the milestones: 4.9.0, 4.10.0 Mar 2, 2022
@larsen0815
Copy link

Still exists in 4.10.1

@sgiehl sgiehl self-assigned this Aug 3, 2022
@sgiehl sgiehl mentioned this issue Aug 3, 2022
Merged
11 tasks
@justinvelluppillai justinvelluppillai changed the title Unable to test if mod_pagespeed is enabled via CLI Improve URL detection in mod_pagespeed check Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging a pull request may close this issue.

Improve url detection in mod pagespeed check matomo-org/matomo
7 participants
@tsteur @justinvelluppillai @sgiehl @larsen0815 @alexhass @joan31 @asheroto