@gregorg opened this Pull Request on October 10th 2013 Contributor

Used to live import nginx logs to piwik.

@mattab commented on October 13th 2013 Member

Thank you for the PR!

Here is code review (these items will help us merge in core)

Cheers

@gregorg commented on October 14th 2013 Contributor

OK I will do that.

For the Exception, it's due to the method to parse lines: one use regex which throw IndexError exception, mine use a hash which throw KeyError. I think the best method should be to throw a specific exception, say "NotFound", for both and futur classes.

@halfdan commented on October 21st 2013 Member

Thanks for the PR! Really useful :+1:

@mattab commented on October 21st 2013 Member

indeed nice work!

This Pull Request was closed on October 21st 2013
Powered by GitHub Issue Mirror