Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JsonFormat to handle json logs without regex parsing. #120

Merged
merged 8 commits into from Oct 21, 2013

Conversation

gregorg
Copy link
Contributor

@gregorg gregorg commented Oct 10, 2013

Used to live import nginx logs to piwik.

@mattab
Copy link
Member

mattab commented Oct 13, 2013

Thank you for the PR!

Here is code review (these items will help us merge in core)

Cheers

@gregorg
Copy link
Contributor Author

gregorg commented Oct 14, 2013

OK I will do that.

For the Exception, it's due to the method to parse lines: one use regex which throw IndexError exception, mine use a hash which throw KeyError. I think the best method should be to throw a specific exception, say "NotFound", for both and futur classes.

halfdan added a commit that referenced this pull request Oct 21, 2013
Add JsonFormat to handle json logs without regex parsing.
@halfdan halfdan merged commit 8bcfd9f into matomo-org:master Oct 21, 2013
@halfdan
Copy link
Member

halfdan commented Oct 21, 2013

Thanks for the PR! Really useful 👍

@mattab
Copy link
Member

mattab commented Oct 21, 2013

indeed nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants