@tsteur opened this Pull Request on August 28th 2017 Member

When fetching saved report parameters (from the DB options table, parameters that were changed eg when changing sort order etc), we currently fetch the report parameters based on the controller action. If there are many reports available for the same report, they all apply the same viewDataTableParams.

One problem is, whenever someone changes the report, those parameters will be saved towards the Report ID, but not the controller action see https://github.com/piwik/piwik/blob/3.0.5-b2/plugins/CoreHome/javascripts/dataTable.js#L1501-L1509

This means a changed data table will never be applied for some reports. And if it was saved, it would be applied to all entities. This is why the report ID should be preferred over a plain controller action as it included eg also a goal id.

Need to see if tests still pass...

This Pull Request was closed on September 26th 2017
Powered by GitHub Issue Mirror