Better fetching of saved report parameters by report ID #11983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
Needs Review
tsteur
commented
Aug 28, 2017
|
|
||
| $paramsKey = $this->getModule() . '.' . $this->getAction(); | ||
|
|
||
| if (!empty($params)) { |
There was a problem hiding this comment.
It is somewhat duplicated logic from ProcessedReport but didn't want to make the method static etc. Eventually, ProcessedReport will directly work on the report classes instead of some arrays and then we have it only in one place.
tsteur
commented
Aug 28, 2017
| if ($loadViewDataTableParametersForUser) { | ||
| $login = Piwik::getCurrentUserLogin(); | ||
| $params = Manager::getViewDataTableParameters($login, $controllerAction); | ||
| $paramsKey = $controllerAction; | ||
| if (!empty($report) && $controllerAction === $apiAction) { |
There was a problem hiding this comment.
It should be important to only apply it to the "default action" when controller and API is the same, at least for now... Not sure about implications of removing $controllerAction === $apiAction as it could potentially apply settings of eg a table report to a graph report...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fetching saved report parameters (from the DB options table, parameters that were changed eg when changing sort order etc), we currently fetch the report parameters based on the controller action. If there are many reports available for the same report, they all apply the same viewDataTableParams.
One problem is, whenever someone changes the report, those parameters will be saved towards the Report ID, but not the controller action see https://github.com/piwik/piwik/blob/3.0.5-b2/plugins/CoreHome/javascripts/dataTable.js#L1501-L1509
This means a changed data table will never be applied for some reports. And if it was saved, it would be applied to all entities. This is why the report ID should be preferred over a plain controller action as it included eg also a goal id.
Need to see if tests still pass...