Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Check says to delete vendor/szymach/c-pchart/app; doing so breaks Piwik #11978

Closed
GreenReaper opened this issue Aug 27, 2017 · 8 comments · Fixed by #11989
Closed

System Check says to delete vendor/szymach/c-pchart/app; doing so breaks Piwik #11978

GreenReaper opened this issue Aug 27, 2017 · 8 comments · Fixed by #11989
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@GreenReaper
Copy link

GreenReaper commented Aug 27, 2017

The System Check reported:

Directories were found in your Piwik but we didn't expect them.
--> Please delete these directories to prevent errors. <--

Directory to delete: vendor/szymach/c-pchart/app


To delete all these directories at once, you can run this command:
rm -Rf /home/harmony-prod/html/piwik/vendor/szymach/c-pchart/app

However, I did so, and then it started warning me about missing files inside this directory.
After an Apache restart, Piwik failed to load completely:

PHP Warning: require([censored]/piwik/vendor/composer/../szymach/c-pchart/src/Resources/data/constants.php): failed to open stream: No such file or directory in [censored]/piwik/vendor/composer/autoload_real.php on line 70
PHP Fatal error:  require(): Failed opening required '[censored]/piwik/vendor/composer/../szymach/c-pchart/src/Resources/data/constants.php' (include_path='[censored]/piwik/vendor/pear/pear_exception:[censored]/html/piwik/vendor/pear/console_getopt:[censored]/piwik/vendor/pear/pear-core-minimal/src:[censored]/piwik/vendor/pear/archive_tar:.:/usr/share/php:/usr/share/pear') in [censored]/piwik/vendor/composer/autoload_real.php on line 70

Reinstalling from the build's tar.gz resulted in a resumption of the initial System Check warning.

I am on Piwik 3.0.5-b2 on Debian jessie with PHP 5.6.30-0+deb8u1 and a backport of Apache 2.4.25.

@Findus23
Copy link
Member

Seems like a false alarm.

The folder vendor/szymach/c-pchart/app is included in the latest build.zip (even though it seems to only include a cache file)

app
└── cache
    ├── cache.db
    └── index.db

@sgiehl
Copy link
Member

sgiehl commented Aug 30, 2017

The problem is, that those files aren't listed in the manifest.inc.php. Will check why this is the case

@sgiehl
Copy link
Member

sgiehl commented Aug 30, 2017

Ok. Those files aren't included in the build zip, but seems that they might be created under some circumstances. Guess we should exclude them from integrity check.

@sgiehl sgiehl added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Aug 30, 2017
@sgiehl sgiehl added this to the 3.1.0 milestone Aug 30, 2017
@sgiehl sgiehl self-assigned this Aug 30, 2017
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 11, 2017
@slawa-dev
Copy link

@mattab @sgiehl

I just upgraded two server to Piwik 3.1.0

And this comes up in System Check

Directories were found in your Piwik but we didn't expect them.
--> Please delete these directories to prevent errors. <--

Directory to delete: vendor/szymach/c-pchart/app


To delete all these directories at once, you can run this command:
rm -Rf /var/www/example.com/vendor/szymach/c-pchart/app

@mattab mattab reopened this Sep 12, 2017
@goodspeedal
Copy link

Same here, @S1awa , update to Piwik 3.1.0 (I am using bitnami AWS build).
Got the same message in system check.

@mmilano
Copy link

mmilano commented Sep 15, 2017

having.had the same issue with 3.1.0.

if one has gone and deleted these directories (following what the app says),
and there is no backup to restore from,
what can be done to manually restore the files from the piwik install?

@mattab
Copy link
Member

mattab commented Sep 18, 2017

@mmilano it should be safe to delete this directory vendor/szymach/c-pchart/app and don't think you'd need to restore it from backup, or did you experience some problem after deleting it?

Otherwise you can simply re-download Piwik and reupload those files from the piwik ZIP

@mattab
Copy link
Member

mattab commented Sep 18, 2017

Should be fixed in #12060

Could you try upgrading to 3.1.1-b2 and you shouldn't see this integrity message anymore?

@mattab mattab modified the milestones: 3.1.0, 3.1.1 Sep 18, 2017
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Sep 18, 2017
@mattab mattab closed this as completed Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants