Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a different port than 25 for SMTP #11961

Merged
merged 2 commits into from Sep 4, 2017

Conversation

frederikbosch
Copy link
Contributor

@frederikbosch frederikbosch commented Aug 16, 2017

This PR fixes different port than 25 using for SMTP.

I strongly recommend removing this line.

@ini_set("smtp_port", $mailConfig['port']);

That is just an insane line of code. Why would you want to modify the ini setting of the smtp port if it is not used anyway? Why would you want suppress errors for that? Avoid using ini_set at any cost I would say.

@mattab
Copy link
Member

mattab commented Aug 16, 2017

Thanks for the PR @frederikbosch

I strongly recommend removing this line.

This sounds good, would you mind removing it in your PR?

@mattab mattab added this to the 3.1.0 milestone Aug 16, 2017
@frederikbosch
Copy link
Contributor Author

Done.

@mattab mattab merged commit 143273c into matomo-org:3.x-dev Sep 4, 2017
@mattab mattab changed the title Different SMTP ports never used Using a different port than 25 for SMTP Sep 4, 2017
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants