Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to login by Email as well as Username #11959

Closed
tsteur opened this issue Aug 15, 2017 · 2 comments
Closed

Allow to login by Email as well as Username #11959

tsteur opened this issue Aug 15, 2017 · 2 comments
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
3.4.0

Comments

@tsteur
Copy link
Member

tsteur commented Aug 15, 2017

AFAIK it is also possible to use the email to log in. I think it would be useful to show this in the label for better UX eg:

image

I'm not sure if all login plugins allow log in via email. If not, we would actually need an option to remove the "Email" part from this label making this feature more complicated. Maybe could show an info icon behind it instead?
@tsteur tsteur added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Aug 15, 2017
@mattab mattab added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Oct 23, 2017
@Jouveer Jouveer mentioned this issue Jan 17, 2018
Merged
@mattab mattab added this to the 3.3.1 milestone Feb 7, 2018
@mattab
Copy link
Member

mattab commented Feb 7, 2018

AFAIK it is also possible to use the email to log in.

Actually I just realised it does not work to login with email addresses!
Having "login with email" seems so obvious and it's surprising indeed we don't support it yet.
In this context we can either:

  1. change the UI field back to "Username" only
  2. or we actually implement login by Email address

(Looking at the code for 2) it seems not too involved as maybe mostly logic called in authenticateWithPassword has to change)

@mattab mattab changed the title Add email to username label in login screen Allow to login by Email as well as Username Feb 7, 2018
@sgiehl sgiehl mentioned this issue Feb 7, 2018
Merged
@mattab
Copy link
Member

mattab commented Mar 8, 2018

Fixed in #12543 🎉

@mattab mattab closed this as completed Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
3.4.0
Development

No branches or pull requests
2 participants
@tsteur @mattab