@sgiehl opened this Pull Request on August 15th 2017 Member

Exporting reports is currently done using the export icon in footer. Clicking on it shows a dropdown to choose the format.

The PR implements an overlay which is shown upon clicking the export icon in datatable footer.
This provide additional possibilities to change configurations for export like format, row limit and maybe others:

image

@mattab @tsteur Any thoughs on this? Should we maybe also make it possible to change date, period and similar things in kind of "advanced options" in this overlay?

EDIT by matt: will fix https://github.com/piwik/piwik/issues/8314

@tsteur commented on August 15th 2017 Member

Looks good to me. Gives us later some more options to eg also add share buttons etc.

Not sure if hard to do but ideally one would be also able to export report as widget (might be more complicated and we have different issue anyway so can be ignored for now).

Be good to later add more options like date / period, show selected segment etc.

@mattab commented on August 16th 2017 Member

Looks good. A very common request from users is about exporting all data and such solution could address this issue.

Feedback:

  • In the row limit field we need an easy way to select "All rows" (the option users are looking for most of the time)
  • add the segment editor and dates/period would also be nice to have (now or later)
@mattab commented on December 15th 2017 Member

This will be a very awesome feature!

Feedback for MVP:

  • in the dashboard, when clicking the export icon, it seems the title in the popover does not get updated and I'm seeing a title of another widget I previously clicked. let me know if you can't reproduce this?
  • In the row limit field, add a "All rows" option somehow (as this will be what users want most of the time)
  • bug: as @mneudert mentioned "When opening a layer the selection list does not extend out of bounds and instead extends the dialog contents vertically with scrollbars. "
  • This is a great opportunity to surface our "Processed metadata" report. Let's add a new dropdown "Report type" which is by default "Standard report", but can be changed to "Report with Metadata". When selected the URL is updated so the []processed metadata report](https://developer.piwik.org/api-reference/reporting-api-metadata) is exported instead.
    • When "Report with metadata" is selected, hide the Export formats that don't support nested datatables ie. hide the following formats: CSV, TSV, HTML, RSS (only XML + JSON work)

Optional / nice to have:

  • Add ability to export via "Iframe embed" the selected report, see https://github.com/piwik/piwik/issues/10208 - which would replicate the behavior from the "Admin > Widgets" page directly within the export capability of each report
@sgiehl commented on January 2nd 2018 Member

@mattab I've done various adjustments to the export popover. it should now handle everything you mentioned as MVP. Additionally for tables that can be flattened / has subtables, it will also show checkbox to flatten the table or to expand the subtables.

@mattab commented on March 22nd 2018 Member

It looks really great and will be very handy, often :tada:

This Pull Request was closed on March 22nd 2018
Powered by GitHub Issue Mirror