New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export overlay for Datatables #11958
Conversation
Looks good to me. Gives us later some more options to eg also add share buttons etc. Not sure if hard to do but ideally one would be also able to export report as widget (might be more complicated and we have different issue anyway so can be ignored for now). Be good to later add more options like date / period, show selected segment etc. |
Looks good. A very common request from users is about exporting all data and such solution could address this issue. Feedback:
|
value="CSV" | ||
ng-model="$parent.reportFormat" | ||
full-width="true" | ||
options="availableReportFormats"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When opening a layer the selection list does not extend out of bounds and instead extends the dialog contents vertically with scrollbars. However this also happens with the limit control in the visitor segment popovers.
The latter are receiving an overflow: auto
from jQuery UI
(.ui-dialog .ui-dialog-content
) while the modals (as used here) have it set by Materialize (.modal
). As both these libraries should have their reasons for setting this it might not be nice to overwrite that setting.
Are there any other options like a radio selection to get around this easily?
7ddeec6
to
963d316
Compare
This will be a very awesome feature! Feedback for MVP:
Optional / nice to have:
|
db4276d
to
bb94a20
Compare
a5bae68
to
e68b1a9
Compare
@mattab I've done various adjustments to the export popover. it should now handle everything you mentioned as MVP. Additionally for tables that can be flattened / has subtables, it will also show checkbox to flatten the table or to expand the subtables. |
784fb27
to
08d9d2f
Compare
8ffdbaa
to
46a727b
Compare
- old popover will be recreated when export popover is closed
It looks really great and will be very handy, often 🎉 |
* Implements export overlay for datatables * use popover instead of modal * use radio instead of select * fix positioning of popover * improve popover; translations * adjust tests * update ui files * add options for flatten & expanded * make export popover work with other popover - old popover will be recreated when export popover is closed * improve export url creation * update ui files
Exporting reports is currently done using the export icon in footer. Clicking on it shows a dropdown to choose the format.
The PR implements an overlay which is shown upon clicking the export icon in datatable footer.
This provide additional possibilities to change configurations for export like format, row limit and maybe others:
@mattab @tsteur Any thoughs on this? Should we maybe also make it possible to change date, period and similar things in kind of "advanced options" in this overlay?
EDIT by matt: will fix #8314