Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: showColumns and hideColumns should also apply to metadata columns #11945

Open
zsoro2 opened this issue Aug 8, 2017 · 2 comments
Open

API: showColumns and hideColumns should also apply to metadata columns #11945

zsoro2 opened this issue Aug 8, 2017 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
For Prioritization

Comments

@zsoro2
Copy link

zsoro2 commented Aug 8, 2017

Hello guys,

I use this api call for get the os families, and i only need the label, but it gives back the logo as well. Any idea? It's a bug or feature?

Query:

https://demo.piwik.org/?module=API&method=DevicesDetection.getOsFamilies&idSite=7&period=day&date=today&format=JSON&token_auth=anonymous&showColumns=label&hideColumns=logo

Response:

[{"label":"Windows","logo":"plugins\/Morpheus\/icons\/dist\/os\/WIN.png"},{"label":"Mac","logo":"plugins\/Morpheus\/icons\/dist\/os\/MAC.png"},{"label":"GNU\/Linux","logo":"plugins\/Morpheus\/icons\/dist\/os\/LIN.png"},{"label":"Android","logo":"plugins\/Morpheus\/icons\/dist\/os\/AND.png"},{"label":"iOS","logo":"plugins\/Morpheus\/icons\/dist\/os\/IOS.png"}]
@mattab
Copy link
Member

mattab commented Sep 18, 2017

Thanks for the report @zsoro2
This is a bug, not a feature 🙂

showColumns and hideColumns should also apply to metadata columns.

@mattab mattab changed the title ShowColumn and HideColumn not working properly API: showColumns and hideColumns should also apply to metadata columns Sep 18, 2017
@mattab mattab added this to the Priority Backlog (Help wanted) milestone Sep 18, 2017
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 18, 2017
@tsteur
Copy link
Member

tsteur commented Sep 18, 2017

If changing this behaviour I would be careful and eg check Piwik mobile etc whether it breaks anything.

@mattab mattab removed this from the Priority Backlog (Help wanted) milestone Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
For Prioritization
Development

No branches or pull requests
4 participants
@tsteur @mattab @zsoro2 @innocraft-automation