copy file instead of renaming it. #11908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As stated in thread; fixes matomo-org#5050
mattab
reviewed
Aug 3, 2017
| @@ -268,7 +268,7 @@ public static function unzipDownloadedFile($path, $unlink = false) | |||
| } | |||
|
|
|||
| $tempFile = GeoIp::getPathForGeoIpDatabase($tempFilename); | |||
| rename($tempFile, $oldDbFile); | |||
| copy($tempFile, $oldDbFile); | |||
There was a problem hiding this comment.
Hi Richard, should we also delete the $tempFile then?
have you had a chance to test this works?
In most cases the rename is successful, in rare cases the rename cannot be completed. In those cases we do a copy, leaving the $tempFile in place, it will be overwritten during the next GeoIPAutopudater task. Tested in both windows and Ubuntu environment.
mattab
added
the
answered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in thread; fixes #5050
Please issue pull request against the
3.x-devbranch only.Piwik 2 is in LTS mode. This means we do not accept any pull request for 2.x except critical security bugs and major data loss bugs.
If you need to create a pull request for 2.x, then please also create the pull request against the
3.x-devso we can merge both.Happy hacking!