This PR is based off https://github.com/piwik/piwik/pull/11857.
Ready for review, but won't resolve conflicts until #11857 is merged.
Left a few comments. Worked for me in general, also in IE10.
Made some changes, if the UI tests pass, should be good to go.
@diosmosis did you squash the last change or so? be good to keep the individual commits so we can more easily review what changed since last time. We can always squash when we merge.
FYI: this ui test is now failing maybe because the title is next to series picker? http://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/24550/UIIntegrationTest_exampleui_treemap.png
Left a comment but looks good to merge otherwise. Only minor tweak needed maybe to prevent possible XSS in the future (currently wouldn't be possible). UI test might need a fix as well.
@tsteur didn't squash, rebased, there was only one different commit in this PR.
@tsteur Tweaked the positioning in treemap visualization so it would look better w/ this change: https://github.com/piwik/plugin-TreemapVisualization/pull/13
Think you could look at that today? Since the branch is in a fork I can't use it as the submodule commit in this PR w/o changing the submodule repo.
I tried to test it but couldn't as the treemap is not rendering for me (I highly doubt it is related to your PR... the canvas element etc has always 0 height) and looks like this:
The tests don't run as it seems to not be able to check out your treemap branch but I trust it is fixed and can be merged 👍
I merged the other branch in treemap plugin. can you maybe update the submodule to use the master branch and then tests will work?
Working on getting the tests to pass, will post a comment when it's all working.
Updated the screenshot, if it passes, this PR is good to go. (Let me know if there's anything else to do for TreemapVisualization, release-wise).
tests pass 👍