write timezone (in our case: always "UTC") in log messages #11893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! in log file it is generally using the timezone abbreviation so let's use |
|
You are right, I should've read a few more lines of the date format character list. I was not aware of |
mattab
added
the
c: Usability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
e(see http://php.net/manual/en/function.date.php) to the Monolog date format. Since Piwik uses "UTC" as the default timezone, this will always add " UTC" to the end of the date string. Log lines will look like this:WARNING Referrers[2017-07-24 18:04:14 UTC] Some messageThis resolves problems with external tools reading the Piwik log. Previously, these tools assumed that the time was displayed in the system timezone. (See for example #2888 (comment) and #11888).