Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\AverageTimeOnSite could not be converted to string #11884

Closed
mattab opened this issue Jul 20, 2017 · 5 comments · Fixed by #11990
Closed

Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\AverageTimeOnSite could not be converted to string #11884

mattab opened this issue Jul 20, 2017 · 5 comments · Fixed by #11990
Assignees
@sgiehl
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Comments

@mattab
Copy link
Member

mattab commented Jul 20, 2017

On demo2 getting all these errors:
could it maybe be a regression in master?

WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\AverageTimeOnSite could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\BounceRate could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\ActionsPerVisit could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\ConversionRate could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\AverageTimeOnSite could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\BounceRate could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\ConversionRate could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\ActionsPerVisit could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\AverageTimeOnSite could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\BounceRate could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\ActionsPerVisit could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\ConversionRate could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\AverageTimeOnSite could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\BounceRate could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\ActionsPerVisit could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\ConversionRate could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\BounceRate could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\ConversionRate could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\AverageTimeOnSite could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\ActionsPerVisit could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\BounceRate could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\ConversionRate could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\ActionsPerVisit could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\AverageTimeOnSite could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\AverageTimeOnSite could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\BounceRate could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\ActionsPerVisit could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\ConversionRate could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\BounceRate could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
WARNING: /storage/piwik-demo2/www/demo2.piwik.org/core/DataTable/Renderer/Console.php(149): Recoverable Error - Object of class Piwik\Plugins\CoreHome\Columns\Metrics\AverageTimeOnSite could not be converted to string - Piwik 3.0.4 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 20, 2017
@mattab mattab added this to the 3.0.5 milestone Jul 20, 2017
@sgiehl
Copy link
Member

sgiehl commented Jul 20, 2017

There were no changes in the corresponding pieces of code, so guess the error was there a bit longer.
Problem is that the ProcessedMetrics are added to the DataTable Metadata. The Console-Renderer tries to echo all metadata of the data table. As the Columns do not implement a __toString method an error occurs.

Actually that should be easy to fix. But I'm not sure what the expected behavior would be here. Should the object be serialized or should the class name be printed?

@mattab Any thoughts?

@mattab
Copy link
Member Author

mattab commented Jul 21, 2017

Not sure when this is triggered so not sure what the best fix would be. Maybe we can start displaying the classname and/or any "key attribute" from this object in toString?

@sgiehl
Copy link
Member

sgiehl commented Jul 21, 2017

What exactly is that Console Renderer even good for?
I would expect it can print a DataTable on console, e.g. for logging. But It currently outputs some parts with html tags, which doesn't make any sense to me.

@mattab
Copy link
Member Author

mattab commented Jul 24, 2017 •
edited

  • Looks like we should maybe just remove the Console renderer then. Moving to 3.1.0 as it would be a API BC break

@mattab mattab modified the milestones: 3.1.0, 3.0.5 Jul 24, 2017
@sgiehl
Copy link
Member

sgiehl commented Jul 24, 2017

We can also change the Console renderer to output everything in plain text.

@sgiehl sgiehl mentioned this issue Aug 17, 2017
Closed
@sgiehl sgiehl mentioned this issue Aug 30, 2017
Merged
@sgiehl sgiehl self-assigned this Aug 30, 2017
@mattab mattab removed this from the 3.2.0 milestone Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Let console renderer handle objects in metadata correctly matomo-org/matomo
2 participants
@mattab @sgiehl