Ignore table not found errors when removing plugin or measurable settings #11881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgiehl there is also another query using this table, Could we apply the patch there as well? |
|
We could add it. But actually while updating there shouldn't be any settings added before the table was created. |
|
@mattab I wouldn't add the ignore to the inserts. Removing something that doesn't exist is imho no real "failure", but not adding something that should be added is a failure and should be reported as one. |
|
👍 |
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #11067, it might happen the plugin or measurable settings might not have been created when updating from an old version.
Ignoring those table not found errors seems to be the simplest solution, as there is no need to remove anything if the table doesn't exist at all
fixes #11067