@sgiehl opened this Pull Request on July 19th 2017 Member

As described in #11067, it might happen the plugin or measurable settings might not have been created when updating from an old version.

Ignoring those table not found errors seems to be the simplest solution, as there is no need to remove anything if the table doesn't exist at all

fixes #11067

@mattab commented on July 24th 2017 Member

@sgiehl there is also another query using this table,

$sql  = "INSERT INTO $table (`idsite`, `plugin_name`, `setting_name`, `setting_value`) VALUES (?, ?, ?, ?)";

Could we apply the patch there as well?

@sgiehl commented on July 24th 2017 Member

We could add it. But actually while updating there shouldn't be any settings added before the table was created.

@sgiehl commented on July 24th 2017 Member

@mattab I wouldn't add the ignore to the inserts. Removing something that doesn't exist is imho no real "failure", but not adding something that should be added is a failure and should be reported as one.

@mattab commented on August 3rd 2017 Member


This Pull Request was closed on August 3rd 2017
Powered by GitHub Issue Mirror