@DevDaveo opened this Pull Request on July 17th 2017

Here's my PR for #11734.

@sgiehl commented on July 19th 2017 Member

Did you maybe forget to push everything? I can't see where the id should be added to the overview. You've simply added a new data attribute that is not used anywhere.

@DevDaveo commented on July 21st 2017

Actually that's everything. Just wanted to add the website ID to hide it with an userscript from the overview. Maybe we could add a setting to hide in the Piwik settings -> Website -> Manage?

@mattab commented on July 24th 2017 Member

@DevDaveo Could you also display this ID in the tooltip on the Sparkline at the end of each row? Currently reads "Go to dashboard of SITE_NAME" ---> "Go to dashboard of SITE_NAME (Website id XYZ)"

@mattab commented on September 21st 2017 Member

Hi @DevDaveo

please check my previous comment. For now i'll close the PR but we are happy to merge if you can apply the feedback. Thanks!

This Pull Request was closed on September 21st 2017
Powered by GitHub Issue Mirror