Adds UI tests for invalid idSite param #11875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
c: Tests & QA
sgiehl
force-pushed
the
invalidsiteuitest
branch
from
eaab6ac
to
9c36ee2
Compare
|
Slow me missed that one :D Screenshots look as expected I think. There is potentially a third case one if you enter a site with a value being int-casted |
|
hm... shouldn't hurt to add a test for that as well |
|
Actually setting a invalid site currently results in: Imho we maybe shouldn't show such an error message to non super users. Most users might not even understand the error, so maybe we should simply redirect to index or similar. Will create a new issue for this, and won't add a test for it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11848