Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page Overlay broke when jQuery loaded in site #11874

Closed
xyb opened this issue Jul 17, 2017 · 1 comment
Closed

Page Overlay broke when jQuery loaded in site #11874

xyb opened this issue Jul 17, 2017 · 1 comment
Assignees
@mneudert
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
3.1.0

Comments

@xyb
Copy link

xyb commented Jul 17, 2017

Page Overlay failed when my web site using jQuery, and web console have error messages:

followingpages.js?v=1:333
Uncaught TypeError: linkTag.children(...).size is not a function
    at checkHasOneChild (followingpages.js?v=1:333)
    at positionLinkTags (followingpages.js?v=1:228)
    at build (followingpages.js?v=1:118)
    at followingpages.js?v=1:517
    at followingpages.js?v=1:53
    at Object.success (client.js?v=1:163)
    at i (jquery-3.1.0.min.js:2)
    at Object.fireWith [as resolveWith] (jquery-3.1.0.min.js:2)
    at A (jquery-3.1.0.min.js:4)
    at HTMLScriptElement.c (jquery-3.1.0.min.js:4)

see also https://forum.piwik.org/t/page-overlay-broke-when-jquery-loaded-in-site/23901
@mneudert mneudert mentioned this issue Jul 19, 2017
Merged
@sgiehl sgiehl added this to the 3.0.5 milestone Jul 20, 2017
@sgiehl
Copy link
Member

sgiehl commented Jul 20, 2017

The merged PR will solve this special failure, but I guess there might occur other problems depending on the jQuery version the overlayed site is using. If any other errors occur somewhere, please open new issues.

@sgiehl sgiehl closed this as completed Jul 20, 2017
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mneudert mneudert

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
4 participants
@xyb @mattab @mneudert @sgiehl