Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hides "invalid site" error from non-super-users #11870

Merged
merged 1 commit into from Jul 17, 2017
Merged

Hides "invalid site" error from non-super-users #11870

merged 1 commit into from Jul 17, 2017

Conversation

mneudert
Copy link
Member

[refs #11848]

This patch displays the login page for regular users while still showing the "invalid site" message for a super user. That might not be the usual way for this kind of behaviour but is easily changeable by just modifying that check.

As there has been no UITest failing for this change it might be interesting to add a new one to the test suite.

@sgiehl sgiehl added this to the 3.0.5 milestone Jul 14, 2017
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

+1 for adding a UI test

@sgiehl sgiehl merged commit 548428b into matomo-org:3.x-dev Jul 17, 2017
@mneudert mneudert deleted the issue-11848 branch July 17, 2017 20:36
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants