Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When running "git init" and then "git add -A ." in a freshly downloaded Piwik, getting warnings "CRLF will be replaced by LF" #11869

Closed
mattab opened this issue Jul 14, 2017 · 3 comments · Fixed by #11871
Assignees
Milestone

Comments

@mattab
Copy link
Member

mattab commented Jul 14, 2017

warning: CRLF will be replaced by LF in plugins/LogViewer/libs/phpjs/LICENSE.txt.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in vendor/piwik/decompress/libs/PclZip/gnu-lgpl.txt.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in vendor/piwik/decompress/libs/PclZip/readme.txt.
The file will have its original line endings in your working directory.
@mattab mattab changed the title When running git init and then git add -A . When running "git init" and then "git add -A ." in a freshly downloaded Piwik, getting warnings "CRLF will be replaced by LF" Jul 14, 2017
@mattab
Copy link
Member Author

mattab commented Jul 14, 2017

It would be great to tackle this and ensure there is no such warning displayed. How can we prevent this issue going forward?

@mattab mattab added this to the 3.0.5 milestone Jul 14, 2017
@mattab
Copy link
Member Author

mattab commented Jul 14, 2017

The core files are then showing up in the system check as failing integrity:

Errors below may be due to a partial or failed upload of Piwik files.
--> Try to reupload all the Piwik files in BINARY mode. <--

File size mismatch: current/vendor/piwik/decompress/libs/PclZip/gnu-lgpl.txt (expected length: 26934, found: 26430)
File size mismatch: current/vendor/piwik/decompress/libs/PclZip/readme.txt (expected length: 22011, found: 21590)

@sgiehl
Copy link
Member

sgiehl commented Jul 14, 2017

The two PRs above should fix the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants