Updating Angular to version 1.6 #11857
Conversation
…ust use standard promise interface.
Angular 1.6 uses strict equals when matching ng-value values w/ ng-model values, and the available values for boolean radio settings is always '0' or '1'. So we have to make sure the field value is '0'/'1'.
|
UI tests are passing which is promising. @sgiehl maybe you have some feedback as well. we could merge this as soon as 3.0.5 is released and then cut a beta to check whether all plugins builds will pass? |
|
@mattab Will have a closer look the next days, but let's merge after 3.0.5 as you suggested. |
…provider change).
|
Did a quick check on a VM w/ IE9, seems broken on 3.x-dev, not sure why. (Also broken on demo.piwik.org). Some pages don't load (like the dashboard), some look odd, like the visitors log. Known issues? |
|
Nevermind, github LFS notification isn't everywhere. |
|
FYI: We dropped IE9 support with Piwik 3 |
|
That's good, I'll check on ie10 :) |
|
Looks like it's working on ie10. Did a cursory check of dialogs via row actions + a couple pages + the top controls. |
|
Good to hear @diosmosis - we'll merge this in the coming days and cut a beta then |
|
We just released 3.1.0 so now merging this PR so we have time to test in the beta cycle |
This PR can be reviewed commit by commit.
Not sure if this can be merged, I wanted to use
.component()which isn't available in 1.4.Changes:
Notes:
Angular 1.6 should be compatible w/ IE9+, but I haven't tested manually yet. If there's anything that should be tested manually on certain browsers, let me know.