Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes it possible to disable installer via config #11850

Merged
merged 1 commit into from Jul 17, 2017
Merged

Makes it possible to disable installer via config #11850

merged 1 commit into from Jul 17, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 7, 2017 •
edited

If disabled, an error screen will be displayed instead of installer:

image

@sgiehl sgiehl added the Needs Review PRs that need a code review label Jul 7, 2017
@sgiehl sgiehl added this to the 3.0.5 milestone Jul 7, 2017
mneudert
mneudert approved these changes Jul 17, 2017
View reviewed changes
Copy link
Member

@mneudert mneudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Even properly stops you from completing a setup step you are currently in. Like if you have opened the database setup and then disabled the installer it will not continue after submitting the page.

@sgiehl sgiehl merged commit 03ec8cd into 3.x-dev Jul 17, 2017
@sgiehl sgiehl deleted the disableinstaller branch July 17, 2017 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mneudert mneudert mneudert approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @mneudert