Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow empty values when tracking content actions #11844

Merged
merged 4 commits into from Jul 7, 2017
Merged

Disallow empty values when tracking content actions #11844

merged 4 commits into from Jul 7, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 5, 2017

fixes #11841

@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jul 5, 2017
@sgiehl sgiehl added this to the 3.0.5 milestone Jul 5, 2017
sgiehl
sgiehl commented Jul 5, 2017
View reviewed changes
plugins/Contents/Columns/ContentName.php
$contentName = trim($contentName);

if (strlen($contentName) > 0) {
return $contentName;
}

return false;
throw new InvalidRequestParameterException('Param `c_n` must not be empty or filled with whitespaces');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content name is required, so discard tracking request if it's not set

@tsteur
Copy link
Member

tsteur commented Jul 7, 2017

👍

@sgiehl sgiehl merged commit 427b25a into 3.x-dev Jul 7, 2017
@sgiehl sgiehl deleted the fixemptycontentvalues branch July 7, 2017 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

Action table for type '14' / '15' was not found during Actions archiving
2 participants
@sgiehl @tsteur