Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update list of valid hostnames #11836

Merged
merged 2 commits into from Jul 3, 2017
Merged

Update list of valid hostnames #11836

merged 2 commits into from Jul 3, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 3, 2017

@sgiehl sgiehl added the Needs Review PRs that need a code review label Jul 3, 2017
@sgiehl sgiehl added this to the 3.0.5 milestone Jul 3, 2017
@sgiehl sgiehl requested a review from mattab July 3, 2017 09:27
sgiehl
sgiehl commented Jul 3, 2017
View reviewed changes
libs/Zend/Validate/Hostname.php
'ایران' => array(1 => '/^[\x{0621}-\x{0624}\x{0626}-\x{063A}\x{0641}\x{0642}\x{0644}-\x{0648}\x{067E}\x{0686}\x{0698}\x{06A9}\x{06AF}\x{06CC}\x{06F0}-\x{06F9}]{1,30}$/iu'),
'中国' => 'Hostname/Cn.php',
'公司' => 'Hostname/Cn.php',
'网络' => 'Hostname/Cn.php',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: All those keys are overwritten somewhere below with self::VALID_UNICODE_DOMAIN, not sure if that is really correct, but that is what is currently used.

@mattab mattab merged commit 2b3f201 into 3.x-dev Jul 3, 2017
@mattab mattab deleted the updatehostnames branch July 3, 2017 11:53
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattab mattab Awaiting requested review from mattab

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @mattab