Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11410: Optional secure tracker cookie #11834

Closed
wants to merge 2 commits into from
Closed

Fix #11410: Optional secure tracker cookie #11834

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 30, 2017

Please issue pull request against the 3.x-dev branch only.

Piwik 2 is in LTS mode. This means we do not accept any pull request for 2.x except critical security bugs and major data loss bugs.

If you need to create a pull request for 2.x, then please also create the pull request against the 3.x-dev so we can merge both.

Happy hacking!

@sgiehl sgiehl added this to the 3.0.5 milestone Jun 30, 2017
@mattab mattab added the Needs Review PRs that need a code review label Jul 10, 2017
@sgiehl
Copy link
Member

sgiehl commented Jul 19, 2017

Sorry, for the late reply.
There are still failing tests and the built js files needs a refresh.
@dudu84 are you able to handle this?

@sgiehl sgiehl modified the milestones: 3.1.0, 3.0.5 Jul 19, 2017
@ghost
Copy link
Author

ghost commented Jul 20, 2017

@sgiehl No problem. I can handle this on weekend. Is it ok?
By refresh the built js files you mean I need to update my repo and then build the files again?

@sgiehl
Copy link
Member

sgiehl commented Jul 20, 2017

By refresh the built js files you mean I need to update my repo and then build the files again?

Exactly. There have been other changes to piwik.js.

@sgiehl sgiehl closed this Jul 24, 2017
@mattab mattab removed this from the 3.2.0 milestone Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants