JS Tracker: new setCrossDomainLinkingTimeout function useful to set a higher timeout for links #11828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… higher timeout for links and increasing the default to 120 seconds
sgiehl
requested changes
Jun 29, 2017
js/piwik.js
Outdated
|
|
||
| if (timeoutInSeconds <= 0) { | ||
| return true; | ||
| } | ||
| if (currentTimestampInSeconds >= timestampInUrl | ||
| && currentTimestampInSeconds <= (timestampInUrl + timeoutInSeconds)) { | ||
| // we only use visitorId if it was generated max 45 seconds ago |
There was a problem hiding this comment.
comment is outdated, as it's not 45 seconds, but configVisitorIdUrlParameterTimeoutInSeconds instead
js/piwik.js
Outdated
| @@ -3089,6 +3089,9 @@ if (typeof window.Piwik !== 'object') { | |||
| // VDI = visitor device identifier | |||
| configVisitorIdUrlParameter = 'pk_vid', | |||
|
|
|||
| // Cross domain linking, the visitor ID is transmitted only in the 180 seconds following the click. | |||
| configVisitorIdUrlParameterTimeoutInSeconds = 120, | |||
There was a problem hiding this comment.
comment says it's 180 seconds, but value actually is 120?
# Conflicts: # js/piwik.min.js # piwik.js
|
Code looks ok now. Let's wait for the tests to pass... |
sgiehl
approved these changes
Jul 17, 2017
|
@mattab Seems some more changes are required here. See https://travis-ci.org/piwik/piwik/jobs/254631350#L498-L550 |
sgiehl
reviewed
Jul 18, 2017
tests/javascript/index.php
Outdated
| @@ -2872,12 +2873,13 @@ function makeReplaceHrefForCrossDomainLink(url) { | |||
| strictEqual(tracker.getTrackerUrl(), makeReplaceHrefForCrossDomainLink(tracker.getTrackerUrl()), 'replaceHrefForCrossDomainLink, should not change URL if href is a tracker URL'); | |||
|
|
|||
| tracker.setUserId('test'); | |||
| debugger; | |||
There was a problem hiding this comment.
@mattab Any reason for adding this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and increasing the default to 120 seconds