Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin.json for Contents plugin #11823

Closed
wants to merge 1 commit into from
Closed

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jun 28, 2017

Without it, it did not load the translation keys on my local installation as it was ignored by the plugin manager.

This is because we check here for a valid plugin structure https://github.com/piwik/piwik/blob/3.0.4/core/Plugin/Manager.php#L301 but Contents has neither plugin.json nor a plugin file

Without it, it did not load the translation keys on my local installation as it was ignored by the plugin manager.

This is because we check here for a valid plugin structure https://github.com/piwik/piwik/blob/3.0.4/core/Plugin/Manager.php#L301 but Contents has neither plugin.json nor a plugin file
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Jun 28, 2017
@tsteur tsteur added this to the 3.0.5 milestone Jun 28, 2017
@sgiehl
Copy link
Member

sgiehl commented Jun 28, 2017

@tsteur
Copy link
Member Author

tsteur commented Jun 28, 2017

true, sorry about that. I must have deleted it accidentally in my branch

@tsteur tsteur closed this Jun 28, 2017
@tsteur tsteur deleted the contentspluginjson branch June 28, 2017 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants