Disallow event tracking with empty/whitespace categories #11819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Needs Review
sgiehl
commented
Jun 26, 2017
js/piwik.js
Outdated
| @@ -4957,7 +4957,7 @@ if (typeof window.Piwik !== 'object') { | |||
| function logEvent(category, action, name, value, customData, callback) | |||
| { | |||
| // Category and Action are required parameters | |||
| if (String(category).length === 0 || String(action).length === 0) { | |||
| if (this.trim(String(category)).length === 0 || this.trim(String(action)).length === 0) { | |||
There was a problem hiding this comment.
This should prevent requests being sent with whitespaced category or action
There was a problem hiding this comment.
Should we log an error to the console in this case?
sgiehl
commented
Jun 26, 2017
| @@ -53,7 +53,7 @@ public static function updateActionsTableWithRowQuery($query, $fieldQueried, & $ | |||
| unset($row[PiwikMetrics::INDEX_SITE_SEARCH_HAS_NO_RESULT]); | |||
| } | |||
|
|
|||
| if (in_array($row['type'], array(Action::TYPE_CONTENT, Action::TYPE_EVENT))) { | |||
| if (in_array($row['type'], array(Action::TYPE_CONTENT, Action::TYPE_EVENT, Action::TYPE_EVENT_NAME))) { | |||
There was a problem hiding this comment.
This should fix the failing archiving for already tracked empty categories.
|
Looks good to me. To be defined if we log an error or not in tracker. |
|
As this case seems currently to be the only case where we "actively" discard an tracking request guess logging an error wouldn't be bad. Updated the PR :) |
|
LGTM if tests pass |
|
Build failure seems not to be related to this changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11623