Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site-select shows ... , when the length of site name is longer than 210px on Firefox 55.0b2. #11815

Closed
pouyana opened this issue Jun 22, 2017 · 7 comments · Fixed by #11839
Closed
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall.
Milestone

Comments

@pouyana
Copy link

pouyana commented Jun 22, 2017

Piwik Version

Piwik version: 3.0.4
MySQL version: 5.5.5
PHP version: 7.0.7
Browser: Firefox 55.0b2 (64-bit)

How to reproduce:

In Firefox add a site with name longer than the 210px (43 chars for example). Instead of showing the 210px first part of the given name it only shows ... which is indistinguishable with other sites. You have to hover over the field to find out which site's statistics you are seeing. I tested the same with chrome and Piwik works correctly there.

@pouyana pouyana changed the title site-select shows ... , when the length of site name is longer than 210px. site-select shows ... , when the length of site name is longer than 210px on Firefox 55.0b2. Jun 22, 2017
@sgiehl
Copy link
Member

sgiehl commented Jun 29, 2017

Maybe an issue of the Firefox beta? It works perfectly in Firefox 54 on Windows.

@pouyana
Copy link
Author

pouyana commented Jul 4, 2017

so in the css-class:

.siteSelector a.title > span {
    max-width: 161px;
    display: inline-block;
    overflow: hidden;
    text-overflow: ellipsis;
}

display: inline-block; makes the difference. Omitting it will show the site name partially again. I don't know if Firefox does it differently in v55 or It is just a Piwik problem.

@Findus23 Findus23 added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Jul 4, 2017
@Findus23
Copy link
Member

Findus23 commented Jul 4, 2017

Hi,
I can reproduce this in Firefox Developer Edition (55.0b6) on Linux.
It works correctly in Chromium and Firefox ESR.

But in Firefox 55 only the ellipsis is printed.
screenshot_20170704_141012

Oddly disabling the following CSS lines doesn't change anything.

overflow: hidden;
text-overflow: ellipsis;

If I change the max-width: to below 155px it also works again. (Changing the width of the surrounding <a> doesn't fix it, but decreasing the font size does.

I think this is a bug in Firefox as this can't be intended.

@Findus23
Copy link
Member

Findus23 commented Jul 4, 2017

I created a minimal example where the error occurs: https://jsfiddle.net/dn993xcL/3/
(unfortunately the css structure is lost in it)

@pouyana
Copy link
Author

pouyana commented Jul 4, 2017

@Findus23 You want to submit to Firefox Bugzilla?
---Edited:
Upstream Bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1378127

@Findus23
Copy link
Member

Findus23 commented Jul 4, 2017

Done: https://bugzilla.mozilla.org/show_bug.cgi?id=1378131

(I hope it is understandable as it's my first bug report at Mozilla)

@Findus23
Copy link
Member

Findus23 commented Jul 4, 2017

To sum it up:

Firefox is behaving as it should and we need to remove the display: inline-block; from the inner span. (which is what @pouyana initially suggested)

Let's see what the UI test says: https://travis-ci.org/piwik/piwik/builds/250107854

Findus23 added a commit that referenced this issue Jul 4, 2017
sgiehl pushed a commit that referenced this issue Jul 17, 2017
sgiehl pushed a commit that referenced this issue Jul 17, 2017
* fix #11815

* move arrow out of text

* Update UI tests
@sgiehl sgiehl added this to the 3.0.5 milestone Jul 17, 2017
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants