Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go through old branches and finish & get them reviewed or delete them #11813

Closed
mattab opened this issue Jun 21, 2017 · 4 comments
Closed

Go through old branches and finish & get them reviewed or delete them #11813

mattab opened this issue Jun 21, 2017 · 4 comments
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Jun 21, 2017

Goal of this issue is to have less opened branches on piwik/piwik. Each Piwik developer with an active branch shall go through each branch in https://github.com/piwik/piwik/branches/yours and either:

  • delete any branch which is not needed / won't get merged,
  • or open a pull request and tag it as WIP when it is useful/ should get merged eventually.
@mattab mattab added this to the 4.0.0 milestone Jun 21, 2017
@tsteur
Copy link
Member

tsteur commented Apr 15, 2020

I just looked and there actually aren't that many left. Closed some branches that I had myself.

@sgiehl @diosmosis @Findus23 Be great to have a look if there are any old branches that can be deleted. Be good to limit it to say 15 minutes. We wouldn't really create any PRs for still open branches though as we wouldn't work on them any time soon anyway.

So be good if everyone could have a quick look and then we can close this issue.

@diosmosis
Copy link
Member

looked through mine and closed most

@mattab
Copy link
Member Author

mattab commented May 5, 2020

also closed my few branches

@tsteur
Copy link
Member

tsteur commented May 5, 2020

closing this issue. @sgiehl @Findus23 feel free to check your branches as well. It's otherwise not too important.

@tsteur tsteur closed this as completed May 5, 2020
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

No branches or pull requests

3 participants