New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segmented visitor log does not load any content when the Outlink URL or Download URL contains an ampersand #11806
Comments
Tried to fix that for a while now, but it seems to be a bit more tricky then I thought. @mneudert would you maybe be keen to have a look here? 🙂 |
I have taken a good look at the behavior and perhaps can explain what is going on (ignoring the potential encoding error in the popup title). To clarify my findings I whipped together some hackish fix. One hackish enough to break a lot of other things completely unrelated... Let's begin the journey with the popup URL getting opened. The URL is both url- and html-encoded ( My first fix was to tell the Expression parser what an A different way might be to double-encode the segmentation parameter. But that seems equally hackish... perhaps Travis can shed some light on what gets broken... |
Hello, When viewing "Segmented visitor log" in outlink report, it seems that if outlinkUrl parameter contain & all the special characters are double encoded. Example :
outlinkUrl parameter in Nginx access log when request segmented visitor log :
|
Reproduce
&
in the URL such ashttp://demo.piwik.org/index.php?module=SitesManager&action=downloadPiwikTracker&idSite={$IDSITE}&piwikUrl=http://piwik.example.org/
Got
No data:
URL requested was
Expected instead
The visitor log should show all users who clicked on that outlinks.
There seems to be a problem with the encoding, the
&
is encoded too many times and end up asamp
etc.Similar to #10126 #6287 #8395
The text was updated successfully, but these errors were encountered: