Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves / Fixes some UI tests #11802

Merged
merged 4 commits into from Jun 18, 2017
Merged

Improves / Fixes some UI tests #11802

merged 4 commits into from Jun 18, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 18, 2017

  • Improves UIIntegrationTest_fatal_error_safemode by overwriting all shown version numbers of plugins. This eliminates the need to update the screenshot with every new plugin release.

  • Fixes Overlay_page_new_links, which was failing a long time already

  • Fixes Dashboard_rowevolution, which was added to prevent new regressions, but wasn't working correctly

fixes #11550

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jun 18, 2017
@sgiehl sgiehl added this to the 3.0.5 milestone Jun 18, 2017
@sgiehl
Copy link
Member Author

sgiehl commented Jun 18, 2017

UI tests passed again 🎉 Merging...

@sgiehl sgiehl merged commit 82aef15 into 3.x-dev Jun 18, 2017
@sgiehl sgiehl deleted the improveuitest branch June 18, 2017 19:32
@mattab
Copy link
Member

mattab commented Jun 19, 2017

Excellent! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Overlay UI tests are failing
2 participants