Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to view Ecommerce Log with segment #11801

Merged
merged 4 commits into from Jun 18, 2017
Merged

Make it possible to view Ecommerce Log with segment #11801

merged 4 commits into from Jun 18, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 18, 2017

fixes #11788

@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jun 18, 2017
@sgiehl sgiehl added this to the 3.0.5 milestone Jun 18, 2017
sgiehl
sgiehl commented Jun 18, 2017
View reviewed changes
plugins/Ecommerce/Controller.php Outdated
} else {
$_GET['segment'] = 'visitEcommerceStatus!=none';
}
$_SERVER['QUERY_STRING'] = http_build_query($_GET);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to overwrite QUERY_STRING, as well, as it is used here https://github.com/piwik/piwik/blob/3.x-dev/core/API/Request.php#L408-L415

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to use Http::buildQuery() for this as there need to be 2 more params set. Otherwise it won't work on some systems (result is different on some servers)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it.

@tsteur
Copy link
Member

tsteur commented Jun 18, 2017

LGTM

@sgiehl sgiehl merged commit 6b860f9 into 3.x-dev Jun 18, 2017
@sgiehl sgiehl deleted the ecommercelogwithsegment branch June 18, 2017 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.1.0
2 participants
@sgiehl @tsteur