New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] splitting up responsibilities in Archive.php #11800
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
added
Needs Review
PRs that need a code review
Pull Request WIP
Indicates the current pull request is still work in progress and not ready yet for a review.
labels
Jun 20, 2017
@diosmosis Thanks for the PR! The concepts exposed look good. We have a short discussion with @tsteur @sgiehl and thought it makes sense so far. 👍 |
Note: because ID archives aren't saved for tables w/ no visits, if there are no visits, the blob archive table won't be created (because ::getBlobTable()) won't be called.
…d not have side effects, side effects must be explicit.
Closing, will open a new PR with smaller changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Review
PRs that need a code review
Pull Request WIP
Indicates the current pull request is still work in progress and not ready yet for a review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a Proof of concept, so should not be merged. I want to get these ideas vetted before moving forward.
Changes in this PR
$idArchives
cache in Archive.php to a separate class that is loaded through DI. This decouples the cache from the specific Archive instance that holds it. It also makes the cache last throughout a request.Changes that haven't been made yet
These don't have to be done in a single PR.
Purpose
The purpose of these changes are to allow plugins to do the following things:
Together this will allow re-using other plugins' API methods that serve reports w/ a custom period type and/or disabling the use of the archive tables (so the request always aggregates & doesn't store new data in the archive tables).
Other things it might enable
Eventually the use of a RecordDataStore interface might enable different backends being used for archive data.