Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-Mail addresses with special characters are not working #11796

Open
Findus23 opened this issue Jun 15, 2017 · 3 comments
Open

E-Mail addresses with special characters are not working #11796

Findus23 opened this issue Jun 15, 2017 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.

Comments

@Findus23
Copy link
Member

Findus23 commented Jun 15, 2017

If one tries to add a new user with the email address john's.email@example.com piwik returns The email doesn't have a valid format. even though the address is perfectly valid.
A var_dump($emailAddress) in this line shows that the all special characters get converted to HTML entities.

  • john's.email@example.com => john's.email@example.com
  • "very.unusual.@.unusual.com"@example.com => "very.unusual.@.unusual.com"@example.com
  • !#$%&'*+-/=?^_{|}~@example.com => !#$%&'*+-/=?^_{|}~@example.com
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Jun 21, 2017
@mattab mattab added this to the Priority Backlog (Help wanted) milestone Jun 21, 2017
@mattab mattab removed this from the Priority Backlog (Help wanted) milestone Oct 6, 2017
@Findus23 Findus23 added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Feb 11, 2018
@ghost ghost mentioned this issue Mar 9, 2018
@mattab mattab modified the milestones: 3.3.1, 3.4.0, 3.4.1 Mar 19, 2018
@mattab mattab modified the milestones: 3.5.0, 3.6.0 Apr 23, 2018
@Findus23
Copy link
Member Author

Findus23 commented Jul 1, 2018

In case someone wants to fix this, please take a look at #12611 and the suggested changes there.

@mwithheld
Copy link
Contributor

For testing: valid email addresses like these contain XSS, but should both be accepted and should not break the UI:

  • "<script>alert(1)</script>"@example.com
  • "<script>alert(1)</script>".blah@example.com
  • bloo."<script>_x(fakething)</script>"@example.com

@Starker3
Copy link
Contributor

This is still an issue for users that have special characters in their email.
@mwithheld did you want try to apply the changes from the PR that was closed using the most up to date branch of 4.x-dev?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
5 participants