Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecommerce Log always show segment "visitEcommerceStatus!=none" but should also apply the current selected segment #11788

Closed
mattab opened this issue Jun 13, 2017 · 0 comments · Fixed by #11801
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Jun 13, 2017

In Ecommerce category, our Ecommerce Log shows all the Ecommerce activity on the website. This report selects all visits that have some ecommerce activity by applying the segment visitEcommerceStatus!=none.

When we are looking at a Custom Segment (eg. Visitors from Germany) and then looking at the Ecommerce log, we'd expect to see all the German buyers. However our custom segment is not applied and we're seeing "All visits with an ecommerce interaction".

As this behavior is inconsistent with other Piwik reports and reports (such as Visitor Log), we should apply any pre-selected custom segment to the Ecommerce Log, with an AND condition.

Code: https://github.com/piwik/piwik/blob/3.0.4/plugins/Ecommerce/Controller.php#L100-100

@mattab mattab added this to the 3.0.5 milestone Jun 13, 2017
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Jun 13, 2017
@sgiehl sgiehl self-assigned this Jun 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants