Fix Issue https://github.com/piwik/piwik/issues/11410 #11784
Conversation
… indicates if the cookie is secure or not. Issue #11410
js/piwik.js
Outdated
| * Set cookie secure flag | ||
| */ | ||
| function setSecureCookie(value) { | ||
| isSecureCookie = value == 1 ? true : false; |
There was a problem hiding this comment.
JSLint test fails here. Is there any reason for comparing value with 1? If you want to ensure isSecureCookie contains a Boolean afterwards, you could also cast value to Boolean or simply use isSecureCookie = !!value, which should pass JSLint.
There was a problem hiding this comment.
@sgiehl Hi there! I did the changes you requested, including the minifying. I can see there on my piwik branch but they are not being reflected in the PR. Could you tell me why?
There was a problem hiding this comment.
Can see them on the PR as well, but could you try to rebase your branch and rebuilt the minified file? It's currently conflicting with 3.x-dev branch.
|
@dudu84 do you have time to make the mentioned changes? |
|
@sgiehl Yes, will to until tomorrow. Sorry for the delay. |
|
@sgiehl Hi Stefan, I did the rebase. But it is conflicting now. Could you shed a light, please? |
|
@dudu84 seems your fork is not even with piwik repo. So you need to update your fork before doing the rebase. |
|
Ok. Thanks. I'll close this one. |
fixes #11410