Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piwik 4 refactoring notes #11783

Closed
tsteur opened this issue Jun 12, 2017 · 0 comments · Fixed by #15836
Closed

Piwik 4 refactoring notes #11783

tsteur opened this issue Jun 12, 2017 · 0 comments · Fixed by #15836
Assignees
@sgiehl
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.0.0

Comments

@tsteur
Copy link
Member

tsteur commented Jun 12, 2017 •
edited

I will keep them here in a list for now for simplicity and edit this issue over time.

  • Rename Piwik\Plugin\Segment::setRequiresAtLeastViewAccess to something like setRequiresRegisteredUser or something to make sure what it actually does is hiding it for Anonymous (eg VisitorId, UserId, ...)
  • Change Dimension::configureSegments() to Dimension::configureSegments($segmentsList, $dimensionSegmentsFactory) similar to how Report::configureWidgets and WigdetsList works
@tsteur tsteur added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. labels Jun 12, 2017
@tsteur tsteur added this to the 4.0.0 milestone Jun 12, 2017
@sgiehl sgiehl self-assigned this Apr 20, 2020
@sgiehl sgiehl mentioned this issue Apr 21, 2020
Merged
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Refactors the way segments are configured in dimensions matomo-org/matomo
2 participants
@tsteur @sgiehl