Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segment editor screwing up selected options #11781

Merged
merged 1 commit into from Jul 7, 2017
Merged

Fix segment editor screwing up selected options #11781

merged 1 commit into from Jul 7, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 9, 2017

fixes #11624

@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jun 9, 2017
@sgiehl sgiehl added this to the 3.0.5 milestone Jun 9, 2017
@tsteur
Copy link
Member

tsteur commented Jul 7, 2017

works 👍 failing UI tests are similar to the other PRs so likely not related to this (http://builds-artifacts.piwik.org/piwik/piwik/segmentprops/23457/)

@sgiehl sgiehl merged commit 08098d9 into 3.x-dev Jul 7, 2017
@sgiehl sgiehl deleted the segmentprops branch July 7, 2017 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

Segment settings lost while updating segment
2 participants
@sgiehl @tsteur