Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More generic raw log access #11775

Merged
merged 1 commit into from Jun 29, 2017
Merged

More generic raw log access #11775

merged 1 commit into from Jun 29, 2017

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jun 8, 2017

Instead of hard coding the tables, use our existing Log table classes to configure it dynamically. This way it also works for custom plugins etc. No change log is needed as the log tables are not public API yet.

@tsteur tsteur added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review labels Jun 8, 2017
@tsteur tsteur added this to the 3.0.5 milestone Jun 8, 2017
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@sgiehl sgiehl merged commit 1bad931 into 3.x-dev Jun 29, 2017
@sgiehl sgiehl deleted the tableidcolumns branch June 29, 2017 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants