When tracker is in maintenande mode return HTTP status code 503 (instead of the current 200 and 400 http status cods) #11773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of the current status of 200 or 400 This will make our return code consistent with the UI which also returns 503 while in maintenance mode Learn more about starting a maintenance window: https://piwik.org/faq/how-to-update/faq_154/
|
I'm wondering if some older browsers might display an broken image if another code than 200 is returned for an image. |
sgiehl
requested changes
Jul 19, 2017
| use Piwik\Tests\Framework\Fixture; | ||
| use Piwik\Tests\Framework\TestCase\SystemTestCase; | ||
| use Piwik\Tracker\TrackerConfig; |
There was a problem hiding this comment.
Any reason for adding the new use-Statements? Can't see that they are needed.
sgiehl
approved these changes
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make our return code consistent with the UI which also returns 503 while in maintenance mode
Learn more about starting a maintenance window: https://piwik.org/faq/how-to/faq_111/