@MichaelHeerklotz opened this Pull Request on June 6th 2017

Added $_COOKIE to RequestSet environment.

Plugins like "plugin-QueuedTracking" need this change, because they process requests asynchronously (not with the same PHP context).

See https://github.com/piwik/plugin-QueuedTracking/issues/51

@MichaelHeerklotz commented on June 6th 2017

Travis CI failes because of the setEnvironment() calls in the tests for "plugin-QueuedTracking". These errors will be fixed with another pull request for "plugin-QueuedTracking". I will link it here, once it exists.

@mattab commented on June 14th 2017 Owner

Hi @MichaelHeerklotz
Thank you for your pull request! We're glad you are contributing to Piwik. Do you know when you will be creating the PR in QueuedTracking plugin? Looking forward to the other PR and reviewing them both. Cheers

@MichaelHeerklotz commented on June 19th 2017

Thank you for your feedback!
It took a bit longer than expected, because in order to update the tests, I also had to modify piwik-php-tracker. But the patches should be ready in one or two days now.

@mattab commented on August 3rd 2017 Owner

Hi @MichaelHeerklotz
Do you think you'll have a chance to submit the updated patch? Thanks

@MichaelHeerklotz commented on November 6th 2017

Helllo @mattab patch is now updated, and I also updated the related tests.

@MichaelHeerklotz commented on November 6th 2017
@tsteur commented on November 8th 2017 Owner
This Pull Request was closed on November 8th 2017
Powered by GitHub Issue Mirror