Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twig: "Variable "topMenu" does not exist." may occur #11763

Closed
wants to merge 2 commits into from
Closed

Conversation

mattab
Copy link
Member

@mattab mattab commented Jun 2, 2017

in some edge cases this could be triggered:

The following error just broke Piwik (v3.0.4):
Variable "topMenu" does not exist.
in
/var/www/piwik/plugins/CoreHome/templates/_topBar.twig line 1

in some edge cases this could be triggered with an empty variable
```

The following error just broke Piwik (v3.0.4):

Variable "topMenu" does not exist.

in

/var/www/piwik/plugins/CoreHome/templates/_topBar.twig line 1

```
@mattab mattab added this to the 3.0.5 milestone Jun 2, 2017
@tsteur
Copy link
Member

tsteur commented Jun 2, 2017

Can you explain an example when this happens? If used correctly it shouldn't happen. Wondering if this just hides wrong implementations in the future eg not calling correct setXVariablesView in Controller etc.

@mattab
Copy link
Member Author

mattab commented Jun 21, 2017

Won't merge this as I'm not too sure how this occured

@mattab mattab closed this Jun 21, 2017
@mattab mattab deleted the twig_fatal branch June 22, 2017 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants