Fixes to some local testing issues #11760
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can be reviewed commit by commit.
Changes:
ps
output. In certain environments, (such as the php:5.6-fpm docker container), exiting pre-maturely in aRequestCommand
execution can cause the PHP process to become a zombie, so it remains inps
output. This caused CliMultiTest to hang indefinitely.ThreeVisitsWithCustomEvents
fixture. The default URL depends on the$_SERVER['HTTP_HOST']
value, which during tests depends on the[tests] http_host
INI config. Which means it could be different based on a dev's local environment.SomeVisitsCustomVariablesCampaignsNotHeuristics
fixture, encode the attribution date time. The Piwik tracker doesn't URL encode this value, so the space in the date time value is sent raw. In my environment this caused the request to fail before even getting to Piwik. This might be something that needs to be fixed in a BC way in the PHP tracker too.Should fix #11746