Remove possibility for synchronous ajax requests #11756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Needs Review
|
Awesome to get rid of sync requests finally. Could probably even merge earlier removing all calls to I presume failing tests are not related to this? http://builds-artifacts.piwik.org/piwik/piwik/nosyncajax/23402/ If tests succeed 👍 |
sgiehl
force-pushed
the
nosyncajax
branch
2 times, most recently
from
40e800c
to
ca654aa
Compare
sgiehl
force-pushed
the
nosyncajax
branch
2 times, most recently
from
d574468
to
85914ec
Compare
|
@sgiehl do you think we could maybe merge this earlier than 4.0.0 (cf previous comment)? |
|
The usage of sync ajax requests have been fully removed in #12546 already. I've rebased that branch now. The only remaining thing is to remove the possibility to use sync requests at all. But that shouldn't be merged before 4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were still some last synchronous ajax requests in dashboard management. Don't think it should be a problem to have them async as those requests shouldn't take long.
Not sure if we should maybe move that to next major version, as it might break UI for some plugins
fixes #8246