@sgiehl opened this Pull Request on May 31st 2017 Member

There were still some last synchronous ajax requests in dashboard management. Don't think it should be a problem to have them async as those requests shouldn't take long.

Not sure if we should maybe move that to next major version, as it might break UI for some plugins

fixes #8246

@tsteur commented on July 7th 2017 Member

Awesome to get rid of sync requests finally. Could probably even merge earlier removing all calls to sync=true and then separate PR to hard coded to no longer use sync? This way we would get rid of sync calls earlier but also fine to wait for everything in Piwik 4.

I presume failing tests are not related to this? http://builds-artifacts.piwik.org/piwik/piwik/nosyncajax/23402/

If tests succeed 👍

@mattab commented on August 28th 2018 Member

@sgiehl do you think we could maybe merge this earlier than 4.0.0 (cf previous comment)?

@sgiehl commented on August 28th 2018 Member

The usage of sync ajax requests have been fully removed in #12546 already. I've rebased that branch now. The only remaining thing is to remove the possibility to use sync requests at all. But that shouldn't be merged before 4.0

This Pull Request was closed on January 15th 2020
Powered by GitHub Issue Mirror