Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix word-breaking for long menu items (Firefox) #11750

Merged
merged 2 commits into from Jul 13, 2017
Merged

Fix word-breaking for long menu items (Firefox) #11750

merged 2 commits into from Jul 13, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 30, 2017 •
edited

word-wrap: break-word; works in Firefox. So all browsers should then have the same behavior.

fixes #10614

@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels May 30, 2017
@sgiehl sgiehl added this to the 3.0.5 milestone May 30, 2017
@sgiehl sgiehl force-pushed the wordbreaks branch 2 times, most recently from 8213ed3 to cbbce08 Compare May 30, 2017 15:27
mneudert
mneudert approved these changes Jul 13, 2017
View reviewed changes
Copy link
Member

@mneudert mneudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, now looks consistent amongst Chrome, FireFox and IE10.

@sgiehl sgiehl merged commit c42a44a into 3.x-dev Jul 13, 2017
@sgiehl sgiehl deleted the wordbreaks branch July 13, 2017 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mneudert mneudert mneudert approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

A long goal name will overflow the submenu
2 participants
@sgiehl @mneudert