Improve handling of DevicePlugins to make it extendable #11748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
c: Platform
|
Code looks good 👍 |
|
I'll try to add some more comments in the code to explain everything a bit. But we shouldn't make it official API, I think |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this changes it will be simple to add new browser plugin detections.
I've created a simple plugin for WebGL detection: https://github.com/sgiehl/Piwik-Plugin-DevicePluginWebGL
Will improve and publish that plugin as soon as this gets merged
Note: Due to the adjustments the "cookie" property is now also available in visitor object.
refs #10841
After Merge: