Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show confirmation before giving view access to anonymous user #11744

Merged
merged 2 commits into from Jul 12, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 29, 2017

fixes #11703

@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels May 29, 2017
@sgiehl sgiehl added this to the 3.0.5 milestone May 29, 2017
@@ -162,6 +162,12 @@
<input role="no" type="button" value="{{ 'General_No'|translate }}"/>
</div>

<div class="ui-confirm" id="confirmAnonymousAccess">
<h2>{{ 'UsersManager_AnonymousAccessConfirmation'|translate()|raw }}</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the raw needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess not. Will remove it

@tsteur
Copy link
Member

tsteur commented May 29, 2017

left a comment but looks good otherwise (haven't tested it though but looks like it should work :) )

@sgiehl sgiehl force-pushed the anonymousaccessconfirmation branch from 1ec37b7 to 5b9ebad Compare June 22, 2017 14:55
@sgiehl sgiehl force-pushed the anonymousaccessconfirmation branch from 5b9ebad to 2603b80 Compare June 22, 2017 15:15
@sgiehl sgiehl merged commit c79bec8 into 3.x-dev Jul 12, 2017
@sgiehl sgiehl deleted the anonymousaccessconfirmation branch July 12, 2017 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ask for confirmation before granting Anonymous user a "view" permission on any website
2 participants