Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System Check: "Missing file: /usr/share/piwik//etc/apt/trusted.gpg.d/piwik-keyring-automatic.gpg" when using APT repository #11743

Closed
theraser opened this issue May 29, 2017 · 7 comments
Closed

System Check: "Missing file: /usr/share/piwik//etc/apt/trusted.gpg.d/piwik-keyring-automatic.gpg" when using APT repository #11743

theraser opened this issue May 29, 2017 · 7 comments
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Comments

@theraser
Copy link

Hello,

using Piwik 3.0.4 with Debian 8 you get the following error when calling the "System Status" page:

Errors below may be due to a partial or failed upload of Piwik files.
--> Try to reupload all the Piwik files in BINARY mode. <--

Missing file: /usr/share/piwik//etc/apt/trusted.gpg.d/piwik-keyring-automatic.gpg

I don't think that this is a critical issue but it may confuse beginners ;-) The path after "/usr/share/piwik/" seems to be a little odd.

Here's the repository configuration:

deb http://debian.piwik.org/ piwik main
deb-src http://debian.piwik.org/ piwik main

This error was also mentioned here in March '17 using Piwik 3.0.2.
@jrblevin
Copy link

For what it's worth, I'm seeing exactly the same thing. Like you, I am running Debian 8 and Piwik 3.0.4.

It seems the /usr/share/piwik/ prefix is added erroneously when checking for the file, because the file does exist under /etc/apt/....

@mattab
Copy link
Member

mattab commented Sep 18, 2017

Hi @jrblevin @theraser
Could you please try the patch in #12022 and let us know if it helps at all?

@jrblevin
Copy link

I patched my FileIntegrity.php in place. Of course, now I see a file integrity error about FileIntegrity.php (so I know the check ran again), but unfortunately the error about piwik-keyring-automatic.gpg is still showing up as well.

@jrblevin
Copy link

I’m not sure if this is useful, but in my config/manifest.inc.php, there is a hash entry for "/etc/apt/trusted.gpg.d/piwik-keyring-automatic.gpg". Other files have only relative paths listed there.

@mattab
Copy link
Member

mattab commented Sep 18, 2017

Hi @aureq
It seems that our Debian package has an extra line in the file integrity array in config/manifest.inc.php

Do you know how we could remove this line from the manifest? thanks!

@aureq
Copy link

aureq commented Sep 19, 2017 •
edited

The Makefile in piwik-package is responsible for generating a new manifest.inc.php as the original one is not usable as is. There was one missing line to exclude the package repository GPG key from the manifest.inc.php.

I added a few extra checks:

  • exclude the GPG key
  • perform a syntax check on manifest.inc.php
  • attempt to check if any extra file (through an absolute path) is detected in manifest.inc.php

Piwik 3.1.0-4 is already pushed and provides the updated manifest.inc.php

@Findus23 Findus23 added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 22, 2021
@Findus23
Copy link
Member

As no one reported this issue since, I assume this fix worked for everyone and this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mattab @aureq @Findus23 @theraser @jrblevin