Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a typo #11740

Merged
merged 2 commits into from Jun 21, 2017
Merged

Fixes a typo #11740

merged 2 commits into from Jun 21, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 27, 2017

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels May 27, 2017
@sgiehl sgiehl added this to the 3.0.5 milestone May 30, 2017
@mattab
Copy link
Member

mattab commented Jun 21, 2017

fyi @sgiehl Build fails with

1) Piwik\Tests\Integration\ReleaseCheckListTest::test_piwikJs_minified_isUpToDate

minified /piwik.js is out of date, please re-generate the minified files using instructions in /js/README

Failed asserting that two strings are equal.

@sgiehl
Copy link
Member Author

sgiehl commented Jun 21, 2017

@mattab updated the built piwik.js

@mattab mattab merged commit 45456d5 into 3.x-dev Jun 21, 2017
@mattab mattab deleted the fixtypo branch June 21, 2017 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @mattab