Use limit selection for limitting exports #11729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
haven't tested but looks good to me 👍 |
I was looking for this issue as I thought we had one, but couldn't find it. I'll create one later as it'd be very useful to have a panel to configure the downloads |
mattab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when clicking a download / export link for an report, the
export_limitis used for limiting the records. As this value always defaults to[General] API_datatable_default_limitINI config option.As that value isn't overwritten anywhere there was no possibility to change the limits for the export.
This change removes the
export_limitoption for data tables and uses the selected filter limit instead. That way the download will be limitted to the number selected for the datatable.This is only kind of a quick fix. In the future we should maybe show a limit selection before starting the download instead of using the one for the datatable.