Use DI so plugins can change Custom Piwik JS #11717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
c: Platform
tsteur
added
Pull Request WIP
tsteur
commented
May 18, 2017
| * @param bool &$shouldAddFile Decides whether the tracker file belonging to the given plugin should be added or not. | ||
| * @param string $pluginName The name of the plugin this file belongs to | ||
| */ | ||
| Piwik::postEvent('CustomPiwikJs.shouldAddTrackerFile', array(&$shouldAddFile, $pluginName)); |
There was a problem hiding this comment.
FYI: I was also thinking about posting the event here: https://github.com/piwik/piwik/blob/3.0.4/plugins/CustomPiwikJs/TrackingCode/PiwikJsManipulator.php#L33 but then decided to post it here instead. This is in case the list of files will be also used for something else. Eg if there was a command to list which files were included in piwik.js etc. Can also change it if needed
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title